New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with WavStream looping (Flac, Wav & MP3) #379

Open

pgrAm wants to merge 1 commit into jarikomppa:master from pgrAm:wavstream-loop

pgrAm commented Dec 9, 2024 •

edited

Loading

There were a few issues with WavStreams and looping, fixed here

WavStreamInstance::seek would always take the branch for OGG leading other formats to stop playing after one loop
The sample copying loop was using the incorrect pitch, aSamplesToRead instead of aBufferSize, causing garbage noise at the end of a loop when aSamplesToRead != aBufferSize
logic for WavStreamInstance::hasEnded() differed from that of WavInstance::hasEnded()


          Fix issues with WavStream looping (Flac, Wav & MP3)

03b3a85

pgrAm force-pushed the wavstream-loop branch from 52a4b30 to 03b3a85 Compare

December 9, 2024 05:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet