Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ctx_shift parameter #357

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix: add ctx_shift parameter #357

merged 2 commits into from
Jan 3, 2025

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Jan 3, 2025

This pull request includes changes to the src/llama_engine.cc file to improve code readability and add new parameters to the LoadModelImpl function. The most important changes are:

Code readability improvements:

  • src/llama_engine.cc: Reformatted the kv_cache_types vector to improve readability by aligning the elements in columns.

Functionality enhancements:

  • src/llama_engine.cc: Added a new parameter ctx_shift to the LoadModelImpl function, with a default value of true. This parameter is extracted from the json_body.

Issue: janhq/cortex.cpp#1843

@vansangpfiev vansangpfiev changed the title fix: disable ctx_shift by default fix: Add ctx_shift parameter Jan 3, 2025
@vansangpfiev vansangpfiev marked this pull request as ready for review January 3, 2025 05:57
@vansangpfiev vansangpfiev changed the title fix: Add ctx_shift parameter fix: add ctx_shift parameter Jan 3, 2025
@vansangpfiev vansangpfiev merged commit 8cfadd3 into main Jan 3, 2025
29 checks passed
@vansangpfiev vansangpfiev deleted the fix/deepseek branch January 3, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants