Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/llama_engine.cc
file to improve code readability and add new parameters to theLoadModelImpl
function. The most important changes are:Code readability improvements:
src/llama_engine.cc
: Reformatted thekv_cache_types
vector to improve readability by aligning the elements in columns.Functionality enhancements:
src/llama_engine.cc
: Added a new parameterctx_shift
to theLoadModelImpl
function, with a default value oftrue
. This parameter is extracted from thejson_body
.Issue: janhq/cortex.cpp#1843