-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] - Image Resizer #48
Conversation
…ed UX with combobox and checkbox components
…e selection functionality
- Added directive to ensure the component is handled as client-side component
Thank you @EduardoDePatta, I'm on vacation until 9th September, after that I'm going to have a look! |
@EduardoDePatta This looks very solid! I tweaked structure to be more aligned with other tools in latest commit. I left few minor comments for you to address. This is the preview of updated UI / structure: |
@EduardoDePatta I also noticed that tests are failing for Image resizer
|
- rename variables for clarity - add dynamic resizing information - display dynamic labels - implement quality input validations - set maximum file size - update UI labels and elements - improve code maintainability
@peckz the test likely failed because the Aside from that, all the other corrections have already been made! |
@EduardoDePatta Thanks for resolving conflicts! From their repo:
I might need to update README.md with additional steps. Which OS are you using Windows, Linux, Mac? |
@peckz I tested it on both |
@EduardoDePatta Thanks for info! I think in general, the problem is with MacOS and arm architecture. Those libs are necessary to install on MacOS:
I'm going to merge this and update README.md Thank you for the contribution! |
Hello again!
This PR introduces a new
Image Resizer
page that allows users to resize images in PNG, JPEG, and SVG formats. Supports aspect ratio maintenance, and quality adjustments(jpeg).Key Changes
Utility Functions:
- Added resizeImage, processImageFile, updateWidth, and updateHeight functions to handle image resizing and dimension
adjustments.
New Component:
- Implemented the ImageResize component, which lets users upload, resize, and download images.
Test Suite:
- Added tests to ensure correct functionality, especially for aspect ratio and format handling.
Updated Tools List:
- New tool accessible from the main tools page.
Documentation update:
- The README file was updated to include the new tool in the list of available utilities, with a direct link.
Benefits
OBS:
canvas
in devDependenciesI also considered adding the functionality to crop images, but since this PR is already QUITE LARGE due to the extensive test file, the addition of dependencies, and the refactoring of the image upload component to make it reusable, SEO component, etc, I decided to leave that as a separate task, should this one be approved.