Fix error when showing some special svg due to data url #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svgomg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for this! Does the SVG in #449 fail due to its size? |
I have no idea for this😂 |
no, #449 problem is because of no "xmlns" attribute. it's ok after toggle off the option "remove xmlns". browser can't display normally "image/svg+xml" lack of "xmlns" attribute. for example https://bugzilla.mozilla.org/show_bug.cgi?id=1125667 it works <svg xmlns="http://www.w3.org/2000/svg" width="100" height="100">
<defs><circle cx="50" cy="50" r="50" id="circle" /></defs>
<use href="#circle"/>
</svg>it doesn't work <svg width="100" height="100">
<defs><circle cx="50" cy="50" r="50" id="circle" /></defs>
<use href="#circle"/>
</svg>i think need use 'text/html' as iframe source type, like this: if (noXMLNS) {
this._svgFrame.src = `data:text/html,${encodeURIComponent(`<html><head><style>body{margin:0}</style></head><body>${text}</body></html>`}`;
} else {
this._svgFrame.src = URL.createObjectURL(new Blob([text], { type: 'image/svg+xml' }));
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #449
The bug https://bugzilla.mozilla.org/show_bug.cgi?id=1125667 in the code comment seems have been fixed.
So, it's time to use blob urls. It will resolve the bug #449.