[jaeger] Fix hostname for Elasticsearch service and add CI test #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellspawn679
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
hellspawn679
changed the title
pavelnikolov
approved these changes
Nov 2, 2024
hellspawn679
force-pushed
the
fresh
branch
2 times, most recently
from
070fed4 to
74e48af
Compare
Signed-off-by: mehul <[email protected]>
Signed-off-by: mehul <[email protected]>
Signed-off-by: mehul <[email protected]>
pavelnikolov
reviewed
Nov 2, 2024
| --set elasticsearch.master.replicaCount=1 | ||
| --set elasticsearch.data.replicaCount=0 | ||
| --set elasticsearch.coordinating.replicaCount=0 | ||
| --set elasticsearch.ingest.replicaCount=0" |
There was a problem hiding this comment.
(nit) add empty line at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue this PR fixes
Checklist
[jaeger]or[jaeger-operator])