Added JS C module Support MRAA Examples #49
Conversation
This reverts commit baf1df3.
|
Doh! Looks like we landed on a travis-ci landmine. We'll want to fix to verify style and rendering. We need to make sure this packages cleanly using the build script for Debian. |
fix internal linking error at writeCModule
PBUI work was started from Support/bone101/UI/ which was not being tested,html-proofer throws : internal script /bone101/Support/bone101/PBUI/pbui.js does not exist (line 66) , even when there aren't any issues while serving.
| @@ -36,7 +36,7 @@ clean: | |||
|
|
|||
| test: | |||
| ifdef HTMLPROOFER | |||
| $(HTMLPROOFER) "./bone101" --disable-external --alt-ignore "/.*/" --only-4xx --url-ignore "/#.*/" --url-swap "/bone101:" --file-ignore "/Support/bone101/UI/","/Support/bonecard/create/" | |||
| $(HTMLPROOFER) "./bone101" --disable-external --alt-ignore "/.*/" --only-4xx --url-ignore "/#.*/" --url-swap "/bone101:" --file-ignore "/Support/bone101/UI/","/Support/bone101/PBUI/","/Support/bonecard/create/" | |||
There was a problem hiding this comment.
I plan to reverse this and simply remove the reference to the missing file.
Makefile
Outdated
| @@ -4,10 +4,17 @@ CLOUD9_DIR:=/var/lib/cloud9 | |||
| JEKYLL:=$(shell which jekyll) | |||
| HTMLPROOFER:=$(shell which htmlproofer) | |||
| NPM:=$(shell which npm) | |||
| MRAA:=$(shell which mraa-gpio) | |||
There was a problem hiding this comment.
I believe this will only make on-target. Why is it part of the documentation?
There was a problem hiding this comment.
Oh, I forget that examples are part of the repo too... These need to be split into two repos. :-(
Examples should be built when run.
Makefile
Outdated
|
|
||
| all: ./bone101 | ||
|
|
||
| ./bone101: Makefile _config.yml | ||
| ifdef MRAA |
There was a problem hiding this comment.
Don't do a build here for on-target examples. This build is for the bone101 HTML content.
Makefile
Outdated
| @@ -4,10 +4,17 @@ CLOUD9_DIR:=/var/lib/cloud9 | |||
| JEKYLL:=$(shell which jekyll) | |||
| HTMLPROOFER:=$(shell which htmlproofer) | |||
| NPM:=$(shell which npm) | |||
| MRAA:=$(shell which mraa-gpio) | |||
| EXDIR:= ./examples/extras/C-modulesFromJS/MRAA_Examples/ | |||
There was a problem hiding this comment.
If this needs to be built for packaging, it should be done in another Makefile, perhaps called by this one.
There was a problem hiding this comment.
I'm sorry, i am a little bit confused regarding your comments on the Makefile, presently i have added a Makefile in the examples directory which handles the compilation and that Makefile is called by this main /Makefile , for now i will revert the changes made to the main makefile and keep the Makefile in the examples directory as is.
There was a problem hiding this comment.
That's fine. The top-level Makefile isn't for inclusion on the target, it is for building the package that gets put on the target.
static/bonecard.css
Outdated
| @@ -146,8 +147,8 @@ div.bonecard-micro:before { | |||
| } | |||
|
|
|||
| .bonecard-code .code { | |||
| width: 834px; | |||
| height: 527px; | |||
| width: 844px; | |||
There was a problem hiding this comment.
Why the new dimensions? Goal was for this to be "phone friendly". Please use resolutions that will be good for that.
There was a problem hiding this comment.
I changed the dimensions to try to fix this issue : #28 , will revert the change
removed the calling of MRAA examples makefile from the main Makefile reverted the related changes to the main Makefile reverted the change made to bonecard.code dimensions
* add hardware object functions * changed order of digital button/menu as it blocks first 3 sliders on canvas * fixed slider not working issue : issue was due to all sliders being active at the same time, fixed by proper call of ui.bar.off() :jadonk#47 * added graph drawing functions : needs improvements * changed the order of user leds * commented non necessary console messages
There was a problem hiding this comment.
I just need to fix the one Makefile hack. Can you post to the mailing list giving the https://beagleboard.github.io/-based URL to try out the new BBUI and PBUI code once it is up there?
jadonk/bonescript#170