Fix #2204 #2213
Merged
Fix #2204 #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues discussed in #2204
getSQLScanner(used injsonandjsonbcodecsPlanScan) andgetSQLScanner(used inscanPlanSQLScanner.Scan) in case the destination value is not a pointer but it is ansql.Scanner. At the same time I left the reflection to be used only in cases where chain-following is needed. Otherwise (when the type is directly ansql.Scannerthe reflection will not be used which is a performance gain.scanPlanJSONToJSONUnmarshal.Scanso as not to aggressively assume that the target destination is a pointer because if it is not, it leads to panic. Followed an approach similar to whatjson.Unmarashaldoes.