feat!: overhaul animation configuration #251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still a work in progress and needs more thought.
Goals of this overhaul are:
- Make configuration concise, explicit, and extensible
- Get rid of ambiguity warts like `{ "dots" }` vs `"dots"`
- Introduce a default BAD pattern that is shown when patterns are
misconfigured
- Make it easier to inspect, debug, and compose animations
At the moment, animations are just a mess of types. Maybe it's time to
introduce a proper `Anime` class/interface with methods and everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress and needs more thought.
Goals of this overhaul are:
{ "dots" }vs"dots"and{ my_pat }vs{ pattern = my_pat }At the moment, animations are just a mess of types. Maybe it's time to introduce a proper
Animeclass/interface with methods and everything.When this lands I will release it as part of V2.
Closes #161