Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate with the latest vodml tools #15

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

pahjbo
Copy link
Member

@pahjbo pahjbo commented Mar 20, 2023

this should be harmless otherwise!

@lmichel
Copy link
Contributor

lmichel commented Mar 21, 2023

Dear PAUL,

Your MR consists in adding gradle stuff to the repo.
Can you be more explicit about the purpose of this by e.g. opening a Wiki page or an issue.
I'm also surprised to see here and in all others DM projects duplicated Java code ; is that necessary?
Laurent

@pahjbo
Copy link
Member Author

pahjbo commented Mar 22, 2023

The motivation behind doing this is get people to use the new tooling on all the models and to follow up on the long threads about VODML-IDs to show that most of the models so far do actually flow the patterns in appendix C of the standard document, as I have added that to the validation.

The gradle directory (+small jar) is the standard "bootstrap" that is done for gradle - its presence means that people do not have to install gradle separately - it can be removed if preferred, but then people have to install gradle separately.

@mcdittmar
Copy link
Collaborator

I was kind-of excited to see this.. my first attempt to use gradle was stymied by java version, so didn't get far. I'd like to move away from using Modelio for content, and just use it for diagrams, however.. I did picture gradle as an external tool so was surprised to seem more than just the connective files (ala vodml.properties for the xslt utilities).

@pahjbo
Copy link
Member Author

pahjbo commented Mar 22, 2023

I have removed the gradle wrapper scripts - they are not essential, but just to make life easier - it is necessary for you to install gradle manually now

@lmichel
Copy link
Contributor

lmichel commented Mar 23, 2023

We really need your tools to be promoted, but seeing them on a standard repo seems to be odd. I suggest you to put somewhere (README Woki?) a note telling what it is for and how to use it.

@pahjbo
Copy link
Member Author

pahjbo commented Mar 23, 2023

There is the Readme that explains the basic operation of the tools - however, I will write a note that also covers some more of the philosophy behind the new tooling that I have given in talks in the last few Interops.

Now all that this PR contains is the config files for running the tools - this is exactly equivalent to the config file vo-dml/vo-dml.properties. Though I think that this file is not much use in place for the ant tools as the relative links will be wrong, and the user will have had to manually download the tools repository. The idea of the gradle based stuff is that unless you are developing the tools themselves you do not need to download your own copy of from https://github.com/ivoa/vo-dml (as was previously necessary with the ant based tools), but can work in place in each of the DM standard repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants