Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compose with iam-proxy-italia naming #178

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

peppelinux
Copy link
Member

This PR updates docker compose and all the scripts using iam-proxy-italia instead of satosa-saml2spid

@MdreW
Copy link
Collaborator

MdreW commented Jan 23, 2025

Hi @peppelinux,
I would not rename satosa-saml2spid to iam-proxy-italia.
I would rename the prefix satosa- to iam-proxy-italia-, iam- or iampi-.
The prefix is usefull to recognize the containers member of their compose end is usefull if is same to all.

I add this proposal:
We can add at start of docker-compose file the 'name' key with iam-proxy-italia as project name value.
The project name is used automatically as prefix.
we can rename the service as:

  • nginx
  • mongo
  • satosa (or proxy)

at composer start each container will be named:

  • iam-proxy-italia-nginx-1
  • iam-proxy-italia-mongo-1
  • iam-proxy-italia-satosa-1 (or proxy)

With this system you can use the short name with docker compose or the full name from container command.

Example:

  • from compose - docker compose restart satosa
  • form container - docker container restart iam-proxy-italia-satosa-1

Little add: iam-proxy-italia is a really beautiful and long name, with this I can use a more short name from a single key
example: name: iampi

@MdreW
Copy link
Collaborator

MdreW commented Jan 23, 2025

Another think, today we really need of a named network?
A named network is useful exclusively if you need to add some specific rules or if this network must connect with some other virtual network.
I think that we can remove the named network: in recent docker installation the network is created dynamically at composer startup... and this work fine. I think that is only an old school heritage

@peppelinux peppelinux requested review from MdreW and elisanp January 23, 2025 13:59
Copy link
Collaborator

@MdreW MdreW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine!

@peppelinux peppelinux merged commit 99ef10e into master Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants