Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dynamic Config Push #379

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

virajrk
Copy link
Collaborator

@virajrk virajrk commented Jan 22, 2025

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

Adding support for pushing dynamic config.

[Link to related ISSUE]

Thank you!

@virajrk virajrk force-pushed the dynamoDB branch 2 times, most recently from 16e3a1f to c4738fc Compare January 22, 2025 01:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 64.48598% with 38 lines in your changes missing coverage. Please review.

Project coverage is 77.26%. Comparing base (6854f0a) to head (14e2a5f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
admiral/pkg/clusters/admiralDatabaseClient.go 59.09% 24 Missing and 3 partials ⚠️
admiral/pkg/clusters/types.go 37.50% 2 Missing and 3 partials ⚠️
admiral/pkg/clusters/dynamoDB.go 85.18% 2 Missing and 2 partials ⚠️
admiral/pkg/controller/common/config.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   77.22%   77.26%   +0.03%     
==========================================
  Files          75       75              
  Lines       10420    10519      +99     
==========================================
+ Hits         8047     8127      +80     
- Misses       1958     1968      +10     
- Partials      415      424       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Viraj Kulkarni added 12 commits January 22, 2025 18:16
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
@virajrk virajrk marked this pull request as ready for review January 23, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants