MESH-6019 : Make ingress gateway selection consistent. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 77.22% 77.22% -0.01%
==========================================
Files 75 75
Lines 10417 10420 +3
==========================================
+ Hits 8045 8047 +2
+ Misses 1963 1958 -5
- Partials 409 415 +6 ☔ View full report in Codecov by Sentry. |
Comment on lines
495
to
494
| } else { | ||
| return false | ||
| } |
There was a problem hiding this comment.
nitpick, we can remove this else block and just return false
| func IsIstioIngressGatewayService(svc *k8sV1.Service, key string) bool { | ||
|
|
||
| if svc != nil && len(svc.Labels) > 0 { | ||
| //return svc.Namespace == NamespaceIstioSystem && svc.Labels["app"] == GetAdmiralParams().LabelSet.GatewayApp |
There was a problem hiding this comment.
can we remove this comment?
| @@ -188,7 +188,8 @@ func (s *serviceCache) GetLoadBalancer(key string, namespace string) (string, in | |||
| return lb, 0 | |||
| } | |||
| for _, service := range services { | |||
| if service.Labels["app"] == key { | |||
| if common.IsIstioIngressGatewayService(service, key) { | |||
| //if service.Labels["app"] == key { | |||
There was a problem hiding this comment.
can we remove this comment?
| ingressEndpoint, port := getIngressEndpointAndPort(rc) | ||
| ingressEndpoint, port := rc.ServiceController.Cache.GetLoadBalancer(common.GetAdmiralParams().LabelSet.GatewayApp, common.NamespaceIstioSystem) |
There was a problem hiding this comment.
any reason we pulled the code out of the func?
There was a problem hiding this comment.
No place is using that except this place.
Plan to clean up that method as well. Also func is not doing anything part from sending same thing.
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: vtiwari5 <[email protected]> Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: vtiwari5 <[email protected]> Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: vtiwari5 <[email protected]> Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
shriramsharma
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
Currently admiral load ingress gateway via two point and two different selector getting used.
Moving this only label selector.
Thank you!