Fix merge_images
for strided images
#196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes need to fix this:
strides
toget_combined_bounds_nodata
, even thought we already used it inget_downsampled_vrts
. this meant it was double counting the strided output resolution, leading to that weird rounding error in @taliboliver 's examplegdal_translate
after merging, sincegdal_merge
has no resampling algorithm to guarantee the output bounds.