Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge_images for strided images #196

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

scottstanie
Copy link
Collaborator

Two changes need to fix this:

  1. we were passing strides to get_combined_bounds_nodata, even thought we already used it in get_downsampled_vrts. this meant it was double counting the strided output resolution, leading to that weird rounding error in @taliboliver 's example
  2. Now we do a gdal_translate after merging, since gdal_merge has no resampling algorithm to guarantee the output bounds.

@scottstanie scottstanie merged commit c175aec into isce-framework:main Jan 22, 2024
6 checks passed
@scottstanie scottstanie deleted the merge_images_strided branch February 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant