Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ionospheric correction #185

Merged
merged 57 commits into from
Jan 24, 2024
Merged

Add ionospheric correction #185

merged 57 commits into from
Jan 24, 2024

Conversation

mirzaees
Copy link
Collaborator

@mirzaees mirzaees commented Jan 5, 2024

Module added to calculate tropospheric phase delay for each interferogram

Sara Mirzaee and others added 28 commits December 11, 2023 11:09
Add tropospheric correction module to the workflow
313646d
@scottstanie
Merge branch 'main' into atmosphere
214a2b4
correct datetime datatype and logger message
4e885bd
@mirzaees @scottstanie
remove type=str from argparse
b629b7c 
Co-authored-by: Scott Staniewicz <[email protected]>
remove type=str from argparse
c02a78e
reformatting
58080d9
use dataclass instead of dict
a66dfb8
add pyaps3 to requirements
a3dc75b
change opera-utils version
c97326b
correct typos and use enum instead of literal
badbc33
change warn to warning
1a9115c
@scottstanie
fix warn in `displacement.py
a2ec47b
add the main function to __all__
72598e2
@mirzaees @scottstanie
Apply suggestions from code review
92a77c9 
Co-authored-by: Scott Staniewicz <[email protected]>
add suggestions from review
8dc0fbd
Merge branch 'atmosphere' of https://github.com/mirzaees/dolphin into…
516e1df 
… atmosphere
Merge branch 'atmosphere' of https://github.com/mirzaees/dolphin into…
36ee679 
… atmosphere
Merge branch 'atmosphere' of https://github.com/mirzaees/dolphin into…
a6321f7 
… atmosphere
restructure docstring for dataclass
796e0d0
@mirzaees @scottstanie
remove repeated line
cc7ca1c 
Co-authored-by: Scott Staniewicz <[email protected]>
@mirzaees @scottstanie
correct typo
bfdcdfb 
Co-authored-by: Scott Staniewicz <[email protected]>
change bounds to SNWE
994067f
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (isce-framework#178)
092b7da 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.7 → v0.1.8](astral-sh/ruff-pre-commit@v0.1.7...v0.1.8)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@scottstanie
add overwrite option for atomic_output (isce-framework#179)
5092ad7 
* add option for overwriting in `atomic_output`

* return the outputs from snaphu unwrap
@scottstanie
Use conncomp.tif for connected component rasters (isce-framework#181)
bc62410 
* use GTiff instead of ENVI for conncomps

* add changelog

* fix unw.conncomp test check
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (isce-framework#182)
e583dfc
@scottstanie
Expose --no-unwrap in dolphin config to skip unwrapping (isce-fra…
ecb9b15 
…mework#183)
add ionosphere correction
43959d8
@mirzaees mirzaees requested a review from scottstanie January 5, 2024 18:10
scottstanie
scottstanie approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good!
let's figure out how we can come up with some test for the code to make sure it's doing what we want

src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Show resolved Hide resolved
@mirzaees
Copy link
Collaborator Author

looks pretty good! let's figure out how we can come up with some test for the code to make sure it's doing what we want

Thanks @scottstanie
I will submit a separate PR for testing. Let's merge this if you think it is good

scottstanie
scottstanie approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to figure out how to adjust the group_by_date call in displacement so that we can accommodate two different file naming conventions

src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
src/dolphin/atmosphere/ionosphere.py Outdated Show resolved Hide resolved
@scottstanie scottstanie mentioned this pull request Jan 18, 2024
Merged
mirzaees and others added 13 commits January 19, 2024 10:40
@mirzaees @scottstanie
Apply suggestions from code review
79a18c6 
Co-authored-by: Scott Staniewicz <[email protected]>
remove assert lines
066d2b8
Merge branch 'main' of https://github.com/isce-framework/dolphin into…
45eb8b0 
… ionosphere
Merge branch 'main' of https://github.com/isce-framework/dolphin into…
0217a1d 
… ionosphere
@scottstanie
Merge branch 'main' into ionosphere
dee91ec
@scottstanie
fix my shuffling and missing import from suggestion
e20b804
Merge branch 'ionosphere' of https://github.com/mirzaees/dolphin into…
02f54db 
… ionosphere
move prepare_geomtery to displacement.py
2928aa0
add test for iono and tropo in workflow
e5230a3
add atmospheric correction test data
6848b4a
pre-commit correction
21e325a
remove iono_date_fmt from config file
8faf818
@scottstanie
turn on unwrapping in config to test tropo/iono
1363c3d
scottstanie
scottstanie reviewed Jan 24, 2024
View reviewed changes
tests/test_workflows_displacement.py Outdated
dem_file=dem_file,
geometry_files=opera_static_files_official,
),
unwrap_options=dict(run_unwrap=True),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirzaees since run_unwrap was false here, adding the corrections_options arguments wasn't doing anything- the workflow would exit before trying corrections (no unwrwapped phase means theres nothing to correct)

scottstanie
scottstanie reviewed Jan 24, 2024
View reviewed changes
src/dolphin/utils.py
@@ -557,3 +557,110 @@ def flatten(list_of_lists: Iterable[Iterable[Any]]) -> chain[Any]:

def _format_date_pair(start: DateOrDatetime, end: DateOrDatetime, fmt="%Y%m%d") -> str:
return f"{start.strftime(fmt)}_{end.strftime(fmt)}"


def prepare_geometry(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function might make more sense in the stitching module, but we can revisit later

@scottstanie scottstanie merged commit b92b0b9 into isce-framework:main Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottstanie scottstanie scottstanie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirzaees @scottstanie