Use conncomp.tif for connected component rasters
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirzaees
pushed a commit
to mirzaees/dolphin
that referenced
this pull request
Jan 5, 2024
* use GTiff instead of ENVI for conncomps * add changelog * fix unw.conncomp test check
scottstanie
added a commit
that referenced
this pull request
Jan 24, 2024
* Add tropospheric correction module to the workflow * correct datetime datatype and logger message * remove type=str from argparse Co-authored-by: Scott Staniewicz <[email protected]> * remove type=str from argparse * reformatting * use dataclass instead of dict * add pyaps3 to requirements * change opera-utils version * correct typos and use enum instead of literal * change warn to warning * fix `warn` in `displacement.py * add the main function to __all__ * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * add suggestions from review * restructure docstring for dataclass * remove repeated line Co-authored-by: Scott Staniewicz <[email protected]> * correct typo Co-authored-by: Scott Staniewicz <[email protected]> * change bounds to SNWE * [pre-commit.ci] pre-commit autoupdate (#178) updates: - [github.com/astral-sh/ruff-pre-commit: v0.1.7 → v0.1.8](astral-sh/ruff-pre-commit@v0.1.7...v0.1.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * add `overwrite` option for `atomic_output` (#179) * add option for overwriting in `atomic_output` * return the outputs from snaphu unwrap * Use `conncomp.tif` for connected component rasters (#181) * use GTiff instead of ENVI for conncomps * add changelog * fix unw.conncomp test check * [pre-commit.ci] pre-commit autoupdate (#182) * Expose `--no-unwrap` in `dolphin config` to skip unwrapping (#183) * add ionosphere correction * transform coordinates using rasterio Co-authored-by: Scott Staniewicz <[email protected]> * use rasterio and griddata * skip corrections if inputs are not provided * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * show function outputs more clear * add comment about num_map * use tuple instead of list * use both str and ENUM in dataclass * use better annotation * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * remove assert lines * fix my shuffling and missing import from suggestion * move prepare_geomtery to displacement.py * add test for iono and tropo in workflow * add atmospheric correction test data * pre-commit correction * remove iono_date_fmt from config file * turn on unwrapping in config to test tropo/iono * attempt to fix static layers test data * turn off for now --------- Co-authored-by: Sara Mirzaee <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.