-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ministack planning, create MiniStackPlanner
and refactor internals of
#160
Merged
scottstanie
merged 30 commits into
isce-framework:main
from
scottstanie:refactor-ministack
Nov 16, 2023
Merged
Refactor ministack planning, create MiniStackPlanner
and refactor internals of
#160
scottstanie
merged 30 commits into
isce-framework:main
from
scottstanie:refactor-ministack
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are just the files in the provided `output_folder`, but dont contain all of the outputs.
cant use `DateOrDatetime` yet due to python/mypy#15663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations were:
planning
out which ministacks will be created (it had been done inline insequential.py
and/or in theVRTStack
, which should just read).sequential.py
Since these were all interrelated, it ended up being a large refactor. Also since so much of the date/file logic was being touched, I fixed the other lingering problem of using
date
everywhere internally when there was no reason not to usedatetime
(which would be necessary for any intra-day repeat mission).(1) and (3) are done, and (2) is set up so it'll be a smaller upcoming PR.