Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ministack planning, create MiniStackPlanner and refactor internals of #160

Merged
merged 30 commits into from
Nov 16, 2023

Conversation

scottstanie
Copy link
Collaborator

@scottstanie scottstanie commented Nov 15, 2023

Motivations were:

  1. Start to separate the functionality of reading the input stack from planning out which ministacks will be created (it had been done inline in sequential.py and/or in the VRTStack, which should just read).
  2. Fix the problem that, when running one ministack with a compressed SLC at the start, we don't make the right interferograms
    • it would always use only real SLC dates in the interferogram step
  3. Fix the problem that we had no way of knowing what the "base phase" was for for single ministack runs if we didn't start from the beginning with sequential.py

Since these were all interrelated, it ended up being a large refactor. Also since so much of the date/file logic was being touched, I fixed the other lingering problem of using date everywhere internally when there was no reason not to use datetime (which would be necessary for any intra-day repeat mission).
(1) and (3) are done, and (2) is set up so it'll be a smaller upcoming PR.

these are just the files in the provided `output_folder`, but dont contain all of the outputs.
cant use `DateOrDatetime` yet due to python/mypy#15663
@scottstanie scottstanie merged commit 9c1e9da into isce-framework:main Nov 16, 2023
2 of 4 checks passed
@scottstanie scottstanie deleted the refactor-ministack branch November 26, 2023 19:25
scottstanie added a commit that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant