Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Method Name and Improve HTTP Header Handling in ServiceManager #58

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

irfanghat
Copy link
Owner

Changes

  • Renamed Method:

    • The method list_all_suspended_services has been renamed to list_services_with_status to better reflect its functionality of returning services based on their status, whether suspended or not.
  • Updated Main Function:

    • Modified the call in main.rs to use the updated method name.
  • Added Test Case:

    • Introduced a new test case test_list_services_with_status to validate the functionality of the renamed method.
  • Header Constants:

    • Replaced string literals for HTTP headers with constants (ACCEPT, AUTHORIZATION, CONTENT_TYPE) in multiple places within service_manager.rs for consistency and maintainability.

@irfanghat irfanghat added enhancement New feature or request minor updates Minor updates such as typos etc labels Jul 19, 2024
@irfanghat irfanghat merged commit 8bfda87 into master Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor updates Minor updates such as typos etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant