Skipping generic from root op when it computes slice indices #19767
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jerryyin <[email protected]>
Signed-off-by: jerryyin <[email protected]>
Signed-off-by: jerryyin <[email protected]>
jerryyin
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
qedawkins
requested changes
Jan 22, 2025
jerryyin
force-pushed
the
users/zyin/skip-generic-result-scatter-indices
branch
from
77696dc to
23dc093
Compare
Signed-off-by: jerryyin <[email protected]>
kuhar
reviewed
Jan 22, 2025
Signed-off-by: jerryyin <[email protected]>
qedawkins
approved these changes
Jan 22, 2025
Signed-off-by: jerryyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the linalg.generic to become root op when it is used to compute slice indices. This PR fix #19746. @IanWood1 has help confirmed this will not cause performance degradation compared with another alternative: having scatter op take precedence over generics.
I'd like to thank @qedawkins for providing mentorship to this PR.