[Codegen][Tuner] Add support for per-sku tuning spec #19762
Merged
+68
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
requested review from
kuhar,
antiagainst,
qedawkins,
hanhanW and
MaheshRavishankar
as code owners
kuhar
requested changes
Jan 22, 2025
compiler/src/iree/compiler/Codegen/Common/MaterializeTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
reviewed
Jan 22, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Jan 22, 2025
compiler/src/iree/compiler/Codegen/Common/MaterializeTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Jan 22, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
reviewed
Jan 23, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
bangtianliu
force-pushed
the
support_per_sku
branch
3 times, most recently
from
8019bb2 to
976d388
Compare
bangtianliu
force-pushed
the
support_per_sku
branch
2 times, most recently
from
1483a9c to
95a46e2
Compare
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
reviewed
Jan 23, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/MaterializeTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
reviewed
Jan 23, 2025
compiler/src/iree/compiler/Codegen/Common/MaterializeTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/MaterializeTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/MaterializeTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Jan 23, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Jan 23, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
This LGTM % the minor issue above. But let's wait for one more approval before landing, maybe from @MaheshRavishankar or @qedawkins.
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
force-pushed
the
support_per_sku
branch
from
8c5ff94 to
e7dd660
Compare
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
reviewed
Jan 24, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
approved these changes
Jan 24, 2025
qedawkins
approved these changes
Jan 24, 2025
| // RUN: iree-opt --split-input-file --iree-gpu-test-target=mi300x@hip \ | ||
| // RUN: --pass-pipeline="builtin.module(hal.executable(hal.executable.variant(iree-hal-configure-target-executable-variants{target=rocm})))" \ | ||
| // RUN: --iree-codegen-enable-default-tuning-specs \ | ||
| // RUN: --iree-codegen-notify-transform-strategy-application \ |
There was a problem hiding this comment.
I missed when this flag was added, but it should be named --iree-codegen-test and/or be hidden or something. Not for this PR though.
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Jan 25, 2025
Add the product name (SKU) naming scheme and explain the difference compared to the architecture scheme. This scheme has been supported for a while but not documented. We expect it to become more relevant after the work related to SKU-specific default tuning specs: iree-org#19762. Issue: iree-org#19720 Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Jan 25, 2025
This flag is intended for tests only. Rename it and mark as it as hidden. Requested by @qedawkins in iree-org#19762 (comment). Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
added a commit
that referenced
this pull request
Jan 25, 2025
This flag is intended for tests only. Rename it and mark as it as hidden. Requested by @qedawkins in #19762 (comment). Issue: #19720 Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
added a commit
that referenced
this pull request
Jan 25, 2025
Add the product name (SKU) naming scheme and explain the difference compared to the architecture scheme. This scheme has been supported for a while but not documented. We expect it to become more relevant after the work related to SKU-specific default tuning specs: #19762. Issue: #19720 Signed-off-by: Jakub Kuderski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for per-sku tuning specs, and nd then per-architecture as a fallback, which is relevant to task outlined in #19720.