[GPU] Add a pass to convert accumulating GEMMs to GEMMs #19587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvedhmeshram
requested review from
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss and
hanhanW
as code owners
nirvedhmeshram
force-pushed
the
acc_gemm_to_elementwise
branch
2 times, most recently
from
78481bb to
7735e86
Compare
qedawkins
reviewed
Jan 7, 2025
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/test/convert_accgemm_to_gemm.mlir
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/test/convert_accgemm_to_gemm.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Nirvedh Meshram <[email protected]>
Signed-off-by: Nirvedh Meshram <[email protected]>
nirvedhmeshram
force-pushed
the
acc_gemm_to_elementwise
branch
from
7735e86 to
47c2309
Compare
|
Looks like we have consensus on #19546 that we want this pass for TileAndFuse. |
qedawkins
approved these changes
Jan 7, 2025
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nirvedh Meshram <[email protected]>
kuhar
reviewed
Jan 7, 2025
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Jan 7, 2025
compiler/src/iree/compiler/Codegen/Common/ConvertAccGEMMToGEMMPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nirvedh Meshram <[email protected]>
Signed-off-by: Nirvedh Meshram <[email protected]>
nirvedhmeshram
force-pushed
the
acc_gemm_to_elementwise
branch
from
abc56be to
b7930af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts dispatches with accumulating GEMMs that are doing in place read/write to GEMM + elementwise add.
This is needed for the TileAndFuse path until we find a more permanent fix for #19546