[DispatchCreation] Move the logic to transpose indexing maps into dispatch formation logic. #19412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
reviewed
Dec 8, 2024
| /// transposed with respect to each other. To find more fusion opportunities for | ||
| /// consumer elementwise operation, the indexing maps in the consumer can be | ||
| /// made to "align" with the indexing map of the producer to enhance fusion. | ||
| static bool areOpsFusableAfterInterchangeOfConsumer( |
There was a problem hiding this comment.
Maybe rename this to something like makeConsumerFusableViaInterchange to signal that it modifies the operation? So it's more clear it has side-effects on the indexing maps of the op.
I'm not sure whats going on with the regression tests but otherwise this looks good. I'm glad ElementwiseOpInterchangePattern is getting removed, it was a bit weird and caused some problems
There was a problem hiding this comment.
+1 on the naming suggestion. It sounds clearer to me.
MaheshRavishankar
force-pushed
the
handle_transpose_fusion
branch
3 times, most recently
from
caa1290 to
1387b89
Compare
Groverkss
approved these changes
Dec 20, 2024
nirvedhmeshram
approved these changes
Dec 20, 2024
|
well, I am going to hold off on submitting anything till the new year. |
MaheshRavishankar
force-pushed
the
handle_transpose_fusion
branch
2 times, most recently
from
ea95ca5 to
bef7a87
Compare
MaheshRavishankar
force-pushed
the
handle_transpose_fusion
branch
2 times, most recently
from
2e5ce76 to
b2e5527
Compare
…patch formation logic.
For cases like
```
%0 = linalg.matmul
%1 = linalg.generic {
indexing_maps=[affine_map<(d0, d1) -> (d1, d0)>, ...], ...}
ins(%0, ... : ...) outs(...) {...}
```
some preprocessing patterns convert these to
```
%0 = linalg.matmul
%1 = linalg.generic {
indexing_maps=[affine_map<(d0, d1) -> (d0, d1)>, ...], ...}
ins(%0, ... : ...) outs(...) {...}
```
to make these operations fusable. But these preprocessing are run too
early and doing a spooky-action-at-a-distance.
Instead just move this logic into dispatch formation itself.
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
MaheshRavishankar
force-pushed
the
handle_transpose_fusion
branch
from
b2e5527 to
a020bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases like
some preprocessing patterns convert these to
to make these operations fusable. But these preprocessing are run too
early and doing a spooky-action-at-a-distance.
Instead just move this logic into dispatch formation itself.
Signed-off-by: MaheshRavishankar [email protected]