Bump actions/checkout to v4.1.7. #17703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should (hopefully) fix warnings about "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20" in CI logs. We have been using commit hashes instead of tags, since they are more stable and that was a policy recommendation for Google-managed GitHub repos. Using release tags is easier and more common, so switching back to that style.
benvanik
approved these changes
Jun 19, 2024
|
Two warnings remain: https://github.com/iree-org/iree/actions/runs/9585451135?pr=17703 I'll separately go through and bump the other action versions. |
ScottTodd
added a commit
that referenced
this pull request
Jun 25, 2024
) Follow-up to #17703, updating more actions. Notably this includes updates to artifacts v4: https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/, which includes substantial performance improvements (e.g. PkgCI "Upload wheel artifacts" step 26s --> 4s). That is a _breaking change_: * Artifacts v4 is not cross-compatible with previous versions. For example, an artifact uploaded using v3 cannot be used with actions/download-artifact@v4.
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
This should (hopefully) fix warnings about "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20" in CI logs. For example: https://github.com/iree-org/iree/actions/runs/9575919714  We have been using commit hashes instead of tags, since they are more stable and that was a policy recommendation for Google-managed GitHub repos: https://opensource.google/documentation/reference/github/services#actions > When using a third-party action (one not hosted in a Google-managed org), a fixed version of the action MUST be used by [specifying a specific commit](https://help.github.com/en/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsuses), rather than a branch like "master", or a tagged release, which can be overwritten by any maintainer of the action. Docker images should always be run at a fixed version rather than "latest". Using release tags is easier and more common, so switching back to that style. Signed-off-by: Lubo Litchev <[email protected]>
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
…e-org#17705) Follow-up to iree-org#17703, updating more actions. Notably this includes updates to artifacts v4: https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/, which includes substantial performance improvements (e.g. PkgCI "Upload wheel artifacts" step 26s --> 4s). That is a _breaking change_: * Artifacts v4 is not cross-compatible with previous versions. For example, an artifact uploaded using v3 cannot be used with actions/download-artifact@v4. Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should (hopefully) fix warnings about "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20" in CI logs. For example: https://github.com/iree-org/iree/actions/runs/9575919714
We have been using commit hashes instead of tags, since they are more stable and that was a policy recommendation for Google-managed GitHub repos: https://opensource.google/documentation/reference/github/services#actions
Using release tags is easier and more common, so switching back to that style.