Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect submodules from shark-infra to iree-org. #17614

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Jun 7, 2024

We moved these out of https://github.com/iree-org to make it easier for project contributors to access them at a time when iree-org was defunct, creating repos there took navigating an extraordinary amount of red tape, and the main iree repo was in the https://github.com/openxla GitHub org. Now that the iree repo is back in iree-org and we've updated how we manage access, these repositories can move back too.

GitHub does some automatic redirecting but individual developers may want to run git submodule sync after the repository moves and this change. For developers working in the other repositories directly, run git submodule set-url [remote name] [new url]. For example: git remote set-url origin https://github.com/iree-org/megabump.git

We moved these out of iree-org to make it easier for project contributors to access them at a time when iree-org was defunct and the iree repo was in the openxla GitHub org. Now that the iree repo is back in iree-org and we've updated how we grant access, these repositories can move back too.
@ScottTodd ScottTodd added infrastructure Relating to build systems, CI, or testing cleanup 🧹 labels Jun 7, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow was failing before. This might have made it worse or just been a no-op. Hard to tell :P

this pr: https://github.com/iree-org/iree/actions/runs/9422777482/job/25959787558?pr=17614
previous (soft) failure: https://github.com/iree-org/iree/actions/runs/9024559403/job/24798654413#step:6:53

@ScottTodd
Copy link
Member Author

Nice, CI jobs seem to be taking the move well. When we used Buildkite before, we saw runners failing to fetch submodules until we put git submodule sync in scripts.

@rsuderman
Copy link
Contributor

You will want to check into the submodule bump failure

@ScottTodd
Copy link
Member Author

You will want to check into the submodule bump failure

See my comment. That was failing before (fyi again @renxida )

@ScottTodd ScottTodd merged commit 59fbf3a into iree-org:main Jun 7, 2024
56 of 57 checks passed
@ScottTodd ScottTodd deleted the infra-forks-org-move branch June 7, 2024 21:13
@jpienaar
Copy link
Member

jpienaar commented Jun 9, 2024

Thanks!

LLITCHEV pushed a commit to LLITCHEV/iree that referenced this pull request Jul 30, 2024
We moved these out of https://github.com/iree-org to make it easier for
project contributors to access them at a time when iree-org was defunct,
creating repos there took navigating an extraordinary amount of red
tape, and the main iree repo was in the https://github.com/openxla
GitHub org. Now that the iree repo is back in iree-org and we've updated
how we manage access, these repositories can move back too.

GitHub does some automatic redirecting but individual developers may
want to run `git submodule sync` after the repository moves and this
change. For developers working in the other repositories directly, run
`git submodule set-url [remote name] [new url]`. For example: `git
remote set-url origin https://github.com/iree-org/megabump.git`

Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants