Skip to content

Commit

Permalink
Set MLIR_LINK_MLIR_DYLIB to not link shared libMLIR (#19613)
Browse files Browse the repository at this point in the history
With llvm/llvm-project@10ef20f, support for `MLIR_LINK_MLIR_DYLIB` was
introduced. With `LLVM_LINK_LLVM_DYLIB` set to `ON` at
https://github.com/iree-org/iree/blob/cdf24b9be0354f06879ba08db85ff8a5dbe49b14/build_tools/llvm/llvm_config.cmake#L30,
this setting is propagated to `MLIR_LINK_MLIR_DYLIB`. This break the BYO
LLVM workflow, see #19549, hence, setting to `OFF`.
  • Loading branch information
marbre authored Jan 6, 2025
1 parent 340ffbb commit 1445cef
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions build_tools/llvm/mlir_config.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ if(NOT EXISTS ${LLVM_DIR})
message(FATAL_ERROR "LLVM_DIR (${LLVM_DIR}) does not exist")
endif()

# TODO: Fixes needed to allow setting to `ON` to allow that
# all the tools will use libMLIR shared library
set(MLIR_LINK_MLIR_DYLIB OFF CACHE BOOL "")

# When exceptions are disabled, unwind tables are large and useless
set(LLVM_ENABLE_UNWIND_TABLES OFF CACHE BOOL "")

Expand Down

0 comments on commit 1445cef

Please sign in to comment.