Use Exceptions in onnx importer to avoid importing broken test cases. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
force-pushed
the
onnx-ops-import-exceptions
branch
from
4db52b9 to
2abbaee
Compare
rsuderman
approved these changes
Aug 14, 2024
ScottTodd
added a commit
that referenced
this pull request
Nov 20, 2024
Generated by running `import_onnx_tests.py`. I think the newly failing to import test cases were broken imports (missing data type conversions) that were silently slipping through. Not sure why #9 missed them. Description | Logs link | Tests passing | Tests failing | Total tests -- | -- | -- | -- | -- Baseline | [logs here](https://github.com/iree-org/iree-test-suites/actions/runs/11916224703/job/33208376944) | 786 (65%) | 431 | 1217 This PR | [logs here](https://github.com/iree-org/iree-test-suites/actions/runs/11921958180/job/33227205119?pr=41) | 788 (68%) | 375 | 1163 So all of the broken test cases were failing anyways. Better to mark them as import (or test suite) failures instead of IREE compilation or runtime failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of these cases were allowing errors to slip through as broken test cases. Rather than rely on checking for
Noneor watching the logs, this uses Exceptions as error handling.As a result of fixing these oversights, some broken test cases are deleted. I'm not sure how
update_config_xfails.pywill handle the list of tests changing.Logs from running the import script: https://gist.github.com/ScottTodd/bd327bc7e95485b12a9f9ebdcddf0bc2