Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline: Specify behavior with respect to formatting. #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

progval
Copy link
Contributor

@progval progval commented Apr 22, 2022

This is the only way to format the fallback for multiline-unaware clients
the same way as for multiline-aware clients

Tthis is the only way to format the fallback for multiline-unaware clients
the same way as for multiline-aware clients
@slingamn
Copy link
Contributor

lgtm

@jwheare
Copy link
Member

jwheare commented Apr 25, 2022

I'm not sure. This puts a significant burden on clients when interpreting user input and composing a multiline message.

@progval
Copy link
Contributor Author

progval commented May 29, 2023

So currently, if someone sends this:

BATCH +123 draft/multiline #channel
@batch=123 PRIVMSG #channel :not-bold <0x02>bold
@batch=123 PRIVMSG #channel :unclear
BATCH -123

then irccloud and the current weechat master will display it like this, because they don't implement this PR:

not-bold bold
unclear

and assuming servers don't do any reformatting, then every client not supporting multiline will get this:

PRIVMSG #channel :not-bold <0x02>bold
PRIVMSG #channel :unclear

so they will display it like this:

not-bold bold
unclear

I understand this can be annoying to implement, but we need to either:

  1. accept this solution
  2. propose a different solution
  3. decide it's not a problem

Could we resolve this before weechat ships version 4.0 with draft/multiline support?

@progval
Copy link
Contributor Author

progval commented Sep 2, 2024

Update: weechat released v4.0 without changing its behavior with respect to formatting.

@progval
Copy link
Contributor Author

progval commented Jan 2, 2025

@flashcode As implementer of the multiline spec, could you weigh in on this question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants