Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print all status messages to stderr #959

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Shnatsel
Copy link
Contributor

@Shnatsel Shnatsel commented Jan 13, 2025

in order to fix rustsec/rustsec#1314

This is a behavioral change observable through the command-line interface, it's up to you how breaking you consider that.

@Shnatsel
Copy link
Contributor Author

@tarcieri PTAL

#960 fixes CI and should probably be merged first so we could get actual CI results on this PR.

@tony-iqlusion
Copy link
Member

@Shnatsel can you rebase now that #960 is merged?

@Shnatsel
Copy link
Contributor Author

Done

@tony-iqlusion
Copy link
Member

Since I'm currently too busy to check: does this match the Cargo behavior it's emulating?

@Shnatsel
Copy link
Contributor Author

Yes, this PR matches Cargo behavior. cargo build and cargo clean print their status messages to stderr.

Here are screenshots showing status messages of different severities printed to stderr:

Screenshot from 2025-01-21 22 44 24

Screenshot from 2025-01-21 22 45 32

@tony-iqlusion tony-iqlusion merged commit b0d1ea5 into iqlusioninc:main Jan 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status_warn! macro breaks JSON output
2 participants