New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support broadcast to unsubscribe topic #36

Open

envestcc wants to merge 15 commits into iotexproject:master from envestcc:peers_by_topic

Member

envestcc commented Feb 27, 2023 •

edited

Loading

summary:

Broadcast support unsubscribed topic
add ConnectedPeersByBroadcastTopic

envestcc added 2 commits

February 27, 2023 23:48


          support get connected peers by topic


          update comment

e94f68c

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Show resolved Hide resolved


          add ErrNoPeersToBroadcast

5907a3f

envestcc mentioned this pull request

[p2p] support network separation iotexproject/iotex-core#3817

Open

10 tasks

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved


          return error only fan-out

4f6db12

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Show resolved Hide resolved

dustinxie reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

CoderZhi reviewed

View reviewed changes

p2p.go Outdated Show resolved Hide resolved

p2p.go Outdated Show resolved Hide resolved

envestcc added 4 commits

March 22, 2023 15:10


          publish unsubscribed topic

8e1a5c0


          Merge branch 'master' into peers_by_topic

f7cc41e


          add pubsubManager

9456d29


          move subs to pubsubManager

3f22582

envestcc changed the title ~~support get connected peers by topic~~ support broadcast unsubscribe topic

envestcc changed the title ~~support broadcast unsubscribe topic~~ support broadcast to unsubscribe topic

envestcc marked this pull request as ready for review

August 3, 2023 03:05

envestcc added 4 commits

August 3, 2023 11:15


          add comments

bd4efeb


          update go-version to 1.18.5

21de82c


          fix data race in test

f904457


          update tests

1fd6425

Liuhaai reviewed

View reviewed changes

.github/workflows/go.yml

@@ @@ -16,7 +16,7 @@ jobs: @@
                   - name: Set up Go
                     uses: actions/setup-go@v2
                     with:
-                      go-version: 1.14
+                      go-version: 1.18.5

Member

Liuhaai Dec 26, 2023

upgrading golang in a separate pr

Liuhaai reviewed

View reviewed changes

p2p.go

+              		return err
+              	}
+              	// publishing unsubscribed topic will fail when no connected peers, it should return error
+              	_, subscribed := h.pubsubManager.getSub(topic)

Member

Liuhaai Dec 26, 2023

how is the subscription of topics from connected peers detected?


          Merge remote-tracking branch 'upstream/master' into dep_peers_by_topic

c460de3

envestcc added 2 commits

August 2, 2024 11:18


          update

06161be


          Merge remote-tracking branch 'upstream/master' into peers_by_topic

3ebca52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet