Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota-framework): Introduce committee selection framework with TopStakers (DRAFT) #4793

Open
wants to merge 42 commits into
base: core-protocol/procotol-version-4
Choose a base branch
from

Conversation

piotrm50
Copy link
Contributor

Description of change

This PR introduces a modified committee selection framework, which allows to easily modify the logic to select the committee members from the list of all active validators. This is duplicate of #3903 which targets develop branch directly.

Links to any relevant issues

#2763

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@piotrm50 piotrm50 added the consensus Issues related to the Core Consensus team label Jan 15, 2025
@piotrm50 piotrm50 self-assigned this Jan 15, 2025
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ❌ Failed (Inspect) Jan 16, 2025 10:19am
apps-ui-kit ❌ Failed (Inspect) Jan 16, 2025 10:19am
rebased-explorer ❌ Failed (Inspect) Jan 16, 2025 10:19am
wallet-dashboard ❌ Failed (Inspect) Jan 16, 2025 10:19am

@piotrm50 piotrm50 force-pushed the feat/committee-selection-rebased branch from aeb8a63 to b818108 Compare January 15, 2025 11:40
@piotrm50 piotrm50 marked this pull request as ready for review January 15, 2025 12:01
@piotrm50 piotrm50 requested review from a team, kodemartin and miker83z as code owners January 15, 2025 12:01
@piotrm50 piotrm50 changed the title feat(iota-framework): Introduce committee selection framework with TopStakers feat(iota-framework): Introduce committee selection framework with TopStakers (DRAFT) Jan 15, 2025
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 049d227

✅ Preview: https://rebased-explorer-ggx63xxig-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 049d227

✅ Preview: https://wallet-dashboard-966ot3dgf-iota1.vercel.app

@alexsporn
Copy link
Member

Please rebase on top of the rebased core-protocol/procotol-version-4 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PoC committee selection with TopStakers selection.
4 participants