feat: automatically expand the relevant address in the tx summary #993
Conversation
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…e-readability-of-transaction-view
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
| const history = useHistory(); | ||
| const { tokenInfo } = useContext(NetworkContext); | ||
| const [isExpanded, setIsExpanded] = useState(false); | ||
| const [isExpanded, setIsExpanded] = useState(isPreExpanded ?? true); |
There was a problem hiding this comment.
the basic output doesnt look expanded by default, we should expand all the outputs to see at first glance what is the address that spent it for inputs, and where they got sent for the output part
There was a problem hiding this comment.
it should look like this
There was a problem hiding this comment.
hmm, it was expanded. I'll doublecheck it.
| (cond) => cond.type === UnlockConditionType.Expiration, | ||
| ) as ExpirationUnlockCondition; | ||
| const isExpirationConditionPresent = !!expirationUnlockCondition; | ||
| const isExpirationConditionExpired = |
There was a problem hiding this comment.
this logic is not working, this output 0x4bd228a6f865de501c1a4c55990d968de1ea958c74852860f66e2befabd74cdb0000 was spent by the return address unlock condition, not the address unlock condition, because the output was spent after the time expired
There was a problem hiding this comment.
I feel like we should distinguish between the outputs in the input part, and the outputs in the output part of the tx,
For the inputs, we need to check if the output was spent before or after the expiration time, it should not be checked against "now", but when the output was spent
For the outputs, i feel like we could for now always expand the address unlock condition and call it a day, at least for now
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…e-readability-of-transaction-view
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…e-readability-of-transaction-view
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
|
superseeded by #1027 |
Description of change
Open transaction details
fixes #982.
Type of change
How the change has been tested
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.