Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use nova models on visualizer three #1053

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Feb 2, 2024

Description of change

Fixes #896

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad linked an issue Feb 2, 2024 that may be closed by this pull request
6 tasks
@VmMad VmMad marked this pull request as ready for review February 2, 2024 14:51
@msarcev
Copy link
Collaborator

msarcev commented Feb 5, 2024

Check lint on api

@VmMad VmMad requested a review from msarcev February 6, 2024 09:19
@msarcev msarcev merged commit 9b71714 into dev Feb 6, 2024
3 of 5 checks passed
@msarcev msarcev deleted the feat/nova/update-models branch February 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update visualizer models to nova
2 participants