Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support metadata topics in nova visualizer #1046

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Feat: Support metadata topics in nova visualizer #1046

merged 8 commits into from
Feb 5, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Feb 1, 2024

Description of change

  • Sets new Visualizer to be used only on Nova networks
  • Listens to block-metadata topics and streams updates in novaFeed
  • Colours Blocks in the Visualizer based on TransactionState

Closes #1034

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@msarcev msarcev marked this pull request as draft February 1, 2024 13:38
@msarcev msarcev linked an issue Feb 1, 2024 that may be closed by this pull request
[Task]: Use accepted & confirmed mqtt topics to color accepted/confirmed blocks #1034
Closed
@msarcev msarcev marked this pull request as ready for review February 1, 2024 15:38
VmMad
VmMad approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

client/src/features/visualizer-threejs/VisualizerInstance.tsx Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd merged commit 111c587 into dev Feb 5, 2024
3 of 5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/support-metadata-topics-nova-visualizer branch February 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VmMad VmMad VmMad approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Use accepted & confirmed mqtt topics to color accepted/confirmed blocks
3 participants
@msarcev @begonaalvarezd @VmMad