Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced whitelist and s_lpType with mapping from lpType to address #751

Open
wants to merge 1 commit into
base: refactor/veION-cleanup-fixes
Choose a base branch
from
+89 −109
Open

replaced whitelist and s_lpType with mapping from lpType to address #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/contracts/contracts/veION/interfaces/IveION.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,14 @@ interface IveION {

/**
* @notice Mints a veNFT in exchange for tokens provided.
* @param _tokenAddress Address of the token to use for creating lock. Must be part of whitelisted tokens (i.e. ION/WETH on Velodrome, 80/20 ION/WETH on Balancer).
* @param _lpType Type of the LP token to use for creating lock.
* @param _tokenAmount Amount of tokens to lock (must be approved to contract).
* @param _duration Duration to create lock for (6-24 months).
* @param _to Optional address who owns the NFT.
* @return _tokenId Token ID that was minted.
*/
function createLockFor(
address[] memory _tokenAddress,
LpTokenType[] memory _lpType,
uint256[] memory _tokenAmount,
uint256[] memory _duration,
bool[] memory _stakeUnderlying,
Expand All @@ -115,13 +115,13 @@ interface IveION {

/**
* @notice Mints a veNFT in exchange for tokens provided.
* @param _tokenAddress Address of the token to use for creating lock. Must be part of whitelisted tokens (i.e. ION/WETH on Velodrome, 80/20 ION/WETH on Balancer).
* @param _lpType Type of the LP token to use for creating lock.
* @param _tokenAmount Amount of tokens to lock (must be approved to contract).
* @param _duration Duration to create lock for (6-24 months).
* @return _tokenId Token ID that was minted.
*/
function createLock(
address[] memory _tokenAddress,
LpTokenType[] memory _lpType,
uint256[] memory _tokenAmount,
uint256[] memory _duration,
bool[] memory _stakeUnderlying
Expand All @@ -132,7 +132,7 @@ interface IveION {
* If unlock time has not passed, uses a formula to unlock early with penalty.
* @param _tokenId Token ID.
*/
function withdraw(address _tokenAddress, uint256 _tokenId) external;
function withdraw(LpTokenType _lpType, uint256 _tokenId) external;

/**
* @notice Updates the voting status of a token.
Expand Down
Loading