Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(angular): uniformize quote style #1807

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

arnauddrain
Copy link
Contributor

global.scss is mixing simple and double quotes, so teams that use a code formatter tool like Prettier need to make a useless commit to fix it when starting their project.

Btw thank you so much for Ionic and Capacitor, these tools make my life wonderful!

@mapsandapps mapsandapps self-requested a review October 10, 2023 20:57
@mapsandapps
Copy link
Contributor

Hi @arnauddrain. Thank you for this PR! This is a good thing to fix. Could you please make the same change in the angular-standalone starter?

@arnauddrain
Copy link
Contributor Author

Hello @mapsandapps, of course sorry about missing that, the PR is updated 👍

@mapsandapps mapsandapps changed the title style(angular): uniformize quote style chore(angular): uniformize quote style Oct 10, 2023
Copy link
Contributor

@mapsandapps mapsandapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@mapsandapps mapsandapps merged commit d180f51 into ionic-team:main Oct 10, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants