feat(toggle): add required prop #30156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joselrio
approved these changes
Jan 30, 2025
gnbm
reviewed
Feb 2, 2025
| @@ -290,7 +297,8 @@ export class Toggle implements ComponentInterface { | |||
| } | |||
|
|
|||
| render() { | |||
| const { activated, color, checked, disabled, el, justify, labelPlacement, inputId, name, alignment } = this; | |||
| const { activated, color, checked, disabled, el, justify, labelPlacement, inputId, name, alignment, required } = | |||
| this; | |||
There was a problem hiding this comment.
@OS-giulianasilva Any reason why we have this extra line-break before this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
required={true}.What is the new behavior?
requiredprop to be used for accessibility purposes that adds therequiredattribute to toggle's inner native input.Does this introduce a breaking change?