Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): update label padding to align with the outline input in ionic theme #30152

Merged
merged 14 commits into from
Jan 31, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Jan 23, 2025

Issue number: internal


What is the current behavior?

There were a misalignment between the labels' input and the labels' Textarea.

What is the new behavior?

  • Updates label text padding to match textarea structure
  • Updates helper and counter text padding to match textarea structure
  • Updates e2e tests snapshots to include changes

Does this introduce a breaking change?

  • Yes
  • No

Other information

input preview
textarea preview

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added package: core @ionic/core package type: bug a confirmed bug report labels Jan 23, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner January 23, 2025 11:15
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:57pm

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd self-assigned this Jan 23, 2025
- update textarea border-color;
- update input colors;
- update input border radius;
core/src/components/input/input.ionic.scss Outdated Show resolved Hide resolved
core/src/components/input/input.ionic.scss Outdated Show resolved Hide resolved
core/src/components/textarea/textarea.ionic.scss Outdated Show resolved Hide resolved
core/src/components/textarea/textarea.ionic.scss Outdated Show resolved Hide resolved
@brandyscarney brandyscarney changed the title fix(input): guarantee ionic input label doesn't have horizontal padding so it's aligned with input outline fix(input): update label padding to align with the outline input in ionic theme Jan 28, 2025
@brandyscarney brandyscarney requested review from thetaPC and removed request for BenOsodrac January 28, 2025 16:40
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

core/src/components/input/input.ionic.scss Show resolved Hide resolved
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 94d28ea into next Jan 31, 2025
47 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11544 branch January 31, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants