Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add helperText and errorText properties #30143

Draft
wants to merge 10 commits into
base: feature-8.5
Choose a base branch
from

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 21, 2025

Issue number: resolves #29205


What is the current behavior?

Select does not support helper and error text.

What is the new behavior?

  • Adds support for helperText and errorText
  • Adds parts for helper-text, error-text and supporting-text
  • Adds CSS variables for helper & error text color
  • Adds an e2e test for bottom content with functional tests and screenshot tests

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview


Co-authored-by: swimer11 [email protected]

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 7:36pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Jan 21, 2025
@brandyscarney brandyscarney mentioned this pull request Jan 22, 2025
2 tasks
@brandyscarney brandyscarney marked this pull request as ready for review January 22, 2025 17:18
@brandyscarney brandyscarney requested a review from a team as a code owner January 22, 2025 17:18
@brandyscarney brandyscarney marked this pull request as draft January 22, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant