Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): add checkbox missing focus on tab #30075

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 10, 2024

Issue number: internal


What is the new behavior?

  • Added ion-focusable class to ion-checkbox
  • Replaced ionic focus styles for focus mixin

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Dec 10, 2024
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:59am

@BenOsodrac BenOsodrac marked this pull request as ready for review December 11, 2024 08:59
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 11, 2024 08:59
@BenOsodrac BenOsodrac requested a review from thetaPC December 11, 2024 08:59
@BenOsodrac BenOsodrac merged commit fec23e8 into next Dec 12, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11445-checkbox branch December 12, 2024 08:58
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants