Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tokens): fixed border generated utilityclasses #30067

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(tokens): fixed border generated utilityclasses #30067

merged 2 commits into from
Dec 10, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 9, 2024 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Now the different border tokens will generate the utility-classes with the expected CSS attribute for each one!

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels Dec 9, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 8:47am

@BenOsodrac BenOsodrac marked this pull request as ready for review December 9, 2024 17:46
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 9, 2024 17:46
brandyscarney
brandyscarney approved these changes Dec 9, 2024
View reviewed changes
core/scripts/tokens/utils.js Outdated Show resolved Hide resolved
thetaPC
thetaPC approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit 85e12dd into next Dec 10, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11457 branch December 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd Awaiting requested review from JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenOsodrac @brandyscarney @thetaPC