feat(safe-area): safe area mixin #28224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
changed the title
brandyscarney
requested changes
Jan 31, 2024
| // Add padding for the safe areas on the left and right of the device. | ||
| // @param {string} $start - amount to add to start. | ||
| // @param {string} $end - amount to add to end. | ||
| @mixin safe-area-padding($start, $end) { |
There was a problem hiding this comment.
Is the goal to eventually include the top and bottom padding in this mixin as well? If not I think this should be called safe-area-padding-horizontal.
| padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end)); | ||
| } | ||
| /* stylelint-enable */ | ||
| @include safe-area-padding(null, var(--inner-padding-end)); |
There was a problem hiding this comment.
This is no longer using the --inner-padding-start property:
| Before | After |
.item-divider-inner {
padding-right: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
padding-left: var(--inner-padding-start);
}
:host-context([dir=rtl]) .item-divider-inner {
padding-right: var(--inner-padding-start);
padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
}
[dir=rtl] .item-divider-inner {
padding-right: var(--inner-padding-start);
padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
}
@supports selector(:dir(rtl)) {
.item-divider-inner:dir(rtl) {
padding-right: var(--inner-padding-start);
padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
}
} |
.item-divider-inner {
padding-right: calc(var(--ion-safe-area-right, 0) + var(--inner-padding-end));
}
:host-context([dir=rtl]) .item-divider-inner {
padding-left: calc(var(--ion-safe-area-left, 0) + var(--inner-padding-end));
padding-right: unset;
}
[dir=rtl] .item-divider-inner {
padding-left: calc(var(--ion-safe-area-left, 0) + var(--inner-padding-end));
padding-right: unset;
}
@supports selector(:dir(rtl)) {
.item-divider-inner:dir(rtl) {
padding-left: calc(var(--ion-safe-area-left, 0) + var(--inner-padding-end));
padding-right: unset;
}
} |
|
Closing this because it's starting to get more complex. The complexity doesn't justify the amount of times that safe area is being used in Ionic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The safe area defines the area within a view that isn't covered by a navigation bar, tab bar, toolbar, or other views a view controller might provide.
The safe areas are reliant on the device's direction, not the app's. This leads to using styles like
padding-rightandpadding-left. However, this can cause issues with the app's direction (LTR/RTL). The team needs to add the correct styles, which can lead to either a bigger block of code or forgetting about the fact that it's based on device direction.What is the new behavior?
I added a new mixin that will take accept two values:
startandend. These values are the additional values that the developer wants to add to either--ion-safe-area-leftor--ion-safe-area-right. For example,startwill be added toion-safe-area-leftin ltr andion-safe-area-rightin rtl. Theendwill be added toion-safe-area-rightin ltr andion-safe-area-leftin rtl.The team wouldn't have to manually do the math with the mixin.
Does this introduce a breaking change?
Other information
I only updated the
.item-divider-innerstyle to use the mixin to start with. The point of this PR is to introduce the mixin. Another PR will be created to add the mixin to the styles.