-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoRA Collection Loader make optional LoRA Collection input #7579
Open
skunkworxdark
wants to merge
12
commits into
invoke-ai:main
Choose a base branch
from
skunkworxdark:lora_loader_optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the LoRA Loaders to make the Lora Collection Optional
skunkworxdark
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
January 20, 2025 21:37
github-actions
bot
added
python
PRs that change python files
invocations
PRs that change invocations
labels
Jan 20, 2025
fix typegen
Fix typegen error
fix typegen error
Fix errors with typegen and py3.10 macos-default github tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
PRs that change frontend files
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
LoRA Collection Loader
nodes to make the Lora Collection input OptionalSummary
LoRACollectionLoader, SDXLLoRACollectionLoader & FLUXLoRACollectionLoader changed to make the LoRAs input optional. This will allow a workflow to disable all Loras by simply disconnecting the collection input to the LoRACollectionLoader node.
This will also allow my custom metadata node
Metadata To LoRA Collection
to operate even when the metadata has no LoRA data.Related Issues / Discussions
NA
QA Instructions
Test All three LoRA Collection loader nodes SD1.5, SDXL and Flux separately. Existing functionality should not change
Merge Plan
NA
Checklist
What's New
copy (if doing a release after this PR)