Fix gray box issue (hopefully) #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only works if you have configured the Janus admin API. TODO(karth295): add documentation on setting this up.
There were race conditions because sb[/connection] was not necessarily initialized when it was used in initializing janus. This commit avoids using statebus for non-react code, and thus avoiding problems with accidentally using state before it is defined.
|
For posterity, this is the issue where some people cannot see each other. They occupy a gray square in a group, but nobody can see their video. I believe the issue is a race condition: if you publish your feed before I've also added logging and debug state ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.