fix: dont send firebase messages on CI

.github/workflows/ci.yml

@@ -70,6 +70,6 @@ jobs:
 
       - name: Run tests
         run: |
-          echo DATABASE_URL=${{ secrets.DATABASE_URL }} >> .env.test && echo FIREBASE_SERVICE_ACCOUNT_JSON_CONTENT=${{ secrets.FIREBASE_SERVICE_ACCOUNT_JSON_CONTENT }} >> .env.test
+          echo DATABASE_URL=${{ secrets.DATABASE_URL }} >> .env.test
           pnpm test
         working-directory: ./backend

backend/src/assignment/assignment-scheduler.service.ts

@@ -34,6 +34,10 @@ export class AssignmentSchedulerService {
         )}`,
       );
 
+      if (process.env.CI === 'true') {
+        return;
+      }
+
       const userIds = assignmentsToCreate.map(
         (assignment) => assignment.userId,
       );

backend/src/main.ts

@@ -1,12 +1,30 @@
 import { NestFactory } from '@nestjs/core';
 import { AppModule } from './app.module';
+import firebaseAdmin from 'firebase-admin';
 
 async function bootstrap() {
   const app = await NestFactory.create(AppModule);
   app.setGlobalPrefix('api');
   app.enableCors();
   await app.listen(3000, '0.0.0.0');
 
+  if (firebaseAdmin.apps.length === 0) {
+    const firebaseServiceAccountJsonContent =
+      process.env.FIREBASE_SERVICE_ACCOUNT_JSON_CONTENT;
+
+    if (firebaseServiceAccountJsonContent === undefined) {
+      throw new Error(
+        'FIREBASE_SERVICE_ACCOUNT_JSON_CONTENT environment variable must be set.',
+      );
+    }
+
+    firebaseAdmin.initializeApp({
+      credential: firebaseAdmin.credential.cert(
+        JSON.parse(firebaseServiceAccountJsonContent),
+      ),
+    });
+  }
+
   const appUrl = await app.getUrl();
   console.log(`Flatshare Backend is running on: ${appUrl}`);
 }

backend/src/notifications/notification.ts

@@ -1,23 +1,4 @@
 import { Message, getMessaging } from 'firebase-admin/messaging';
-import firebaseAdmin from 'firebase-admin';
-
-if (firebaseAdmin.apps.length === 0) {
-  const firebaseServiceAccountJsonContent =
-    process.env.FIREBASE_SERVICE_ACCOUNT_JSON_CONTENT;
-
-  // TODO: should probably do the same for all other environment variables too.
-  if (firebaseServiceAccountJsonContent === undefined) {
-    throw new Error(
-      'FIREBASE_SERVICE_ACCOUNT_JSON_CONTENT environment variable must be set.',
-    );
-  }
-
-  firebaseAdmin.initializeApp({
-    credential: firebaseAdmin.credential.cert(
-      JSON.parse(firebaseServiceAccountJsonContent),
-    ),
-  });
-}
 
 export async function sendFirebaseMessages({
   messages,
@@ -29,9 +10,7 @@ export async function sendFirebaseMessages({
   }
 
   const messaging = getMessaging();
-  const response = await messaging.sendEach(messages);
-  if (response.failureCount > 0) {
-    console.error({ loc: JSON.stringify(response.responses) });
-    throw new Error('Did not send all messages!');
-  }
+
+  // TODO: all tokens that error because they are no longer registered should be removed from our table.
+  await messaging.sendEach(messages);
 }

frontend/lib/firebase_options.dart

@@ -4,16 +4,6 @@ import 'package:firebase_core/firebase_core.dart' show FirebaseOptions;
 import 'package:flutter/foundation.dart'
     show defaultTargetPlatform, kIsWeb, TargetPlatform;
 
-/// Default [FirebaseOptions] for use with your Firebase apps.
-///
-/// Example:
-/// ```dart
-/// import 'firebase_options.dart';
-/// // ...
-/// await Firebase.initializeApp(
-///   options: DefaultFirebaseOptions.currentPlatform,
-/// );
-/// ```
 class DefaultFirebaseOptions {
   static FirebaseOptions get currentPlatform {
     if (kIsWeb) {
@@ -65,5 +55,5 @@ class DefaultFirebaseOptions {
     storageBucket: 'flatshare-223fd.firebasestorage.app',
     iosBundleId: 'com.invertedecho.flaatshare',
   );
+}
 
-}