-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FlutterFire CLI is not able to handle projects that use Kotlin DSL for Gradle #306
base: main
Are you sure you want to change the base?
Conversation
…Kotlin DSL for Gradle invertase#305
Okay so I tried running the code on a project with Kotlin DSL files, and for some reason, it is not updating the those files, even though it does write |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Has this been implemented? Still having this issue with my app even with latest dev build. |
Hey @Henry5775 , no i don't think so, last i checked this was still not working. Then I just abandoned using Kotlin DSL and switched to Groovy DSL instead. |
Same here. Wasted so much time trying to find a solution to this. |
#305
Description
Added support for updating
android/build.gradle.kts
,android/settings.gradle.kts
andandroid/app/build.gradle.kts
files.Added
RegExp
s, functions to handle Kotlin Gradle DSL files if Groovy Gradle DSL files are not foundWe assume that the project does not use a mix of Groovy and Kotlin DSL gradle files.
We check whether the
android/build.gradle
file exists or not. If it exists, the existing code handles updating the files.If it does not not exist, we proceed to check whether
android/build.gradle.kts
file exists.If it does, we use Kotlin DSL configuration.
If both configuration files are not found, an Exception is thrown.
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore