Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated sentry instructions #733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented Dec 11, 2024

❤️ Thank you for your contribution!

Description

I think this change will be needed for v13 once invenio-logging is updated.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I've created logical separate commits and followed the commit message format.
  • I've targeted the master branch.
  • If this documentation change impacts the current release of InvenioRDM, I will backport it to the production branch following approval or indicate to a maintainer that it should be backported.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, I remember seeing a pipenv/pip warning about sentry_sdk (or some such extra) missing when going through an instance install even in v12. Does this apply to v12 as well or is this something else? Something to know for the backport of the docs as well.

Feel free to merge when you want and share what if any should be backported 👍

@@ -69,10 +69,10 @@ You can configure Celery, SQLAlchemy, and Redis to send logs to Sentry. This beh

To enable Sentry integration, follow these steps:

- Install the Sentry SDK: In your `Pipefile`, under the packages section, add the invenio-logging package with the sentry_sdk extra:
- Install the Sentry SDK: In your `Pipefile`, under the packages section, add the invenio-logging package with the sentry extra:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for little extra formatting + typo:

Suggested change
- Install the Sentry SDK: In your `Pipefile`, under the packages section, add the invenio-logging package with the sentry extra:
- Install the Sentry SDK: In your `Pipfile`, under the `[packages]` section, add the `invenio-logging` package with the `sentry` extra:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants