forked from FirebaseExtended/firepad
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: code deletion when switching between multiple instances #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
_handleInitialRevisions()
insidefirebase-adapter.ts
was not ceasing operation when thedispose()
method was called. Because thethis._zombie
flag was set to true only once Ready event was triggered. But since this is the first method that is supposed to initialise the text and then trigger the Ready event, the operation in this method would continue executing even if firepad is disposed.To prevent this, the
this._zombie
variable can be used to declare that firepad is now disposed even before triggering the Ready event.This discrepancy has always been there in the code since the migration to typescript. Here is the actual firepad implementation of dispose, note that the _handleInitialRevisions method reset is missing from our fork.
https://github.com/FirebaseExtended/firepad/blob/master/lib/firebase-adapter.js#L70