receipts view #15
Open
receipts view #15
+795
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with: on-click, disabled
jbuckner
reviewed
Jan 15, 2025
| isTest: boolean; | ||
| token: string; | ||
| }; | ||
| export class Receipt { |
There was a problem hiding this comment.
Is there a reason you have the separate type aReceipt and the class Receipt? It seems like you should be able to just have the type since the class is just a container for the data and doesn't have any operations on it.
There was a problem hiding this comment.
hmm, in the constructor of Receipt class, TS is asking to remove implicit any. what's the best way to remove this?
nsharma123
reviewed
Jan 16, 2025
nsharma123
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://internetarchive.github.io/iaux-monthly-giving-circle/pr/pr-15/demo/