-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New precheck procedure to enhance stability. #1453
New precheck procedure to enhance stability. #1453
Conversation
# Conflicts: # dlrover/python/master/args.py # dlrover/python/tests/test_args.py # docs/deployment/argument.md # go/elasticjob/pkg/controllers/master/master.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 82.14% 82.21% +0.06%
==========================================
Files 253 255 +2
Lines 25288 25498 +210
==========================================
+ Hits 20774 20964 +190
- Misses 4514 4534 +20 ☔ View full report in Codecov by Sentry. |
# Conflicts: # dlrover/python/common/global_context.py # dlrover/python/master/diagnosis/diagnosis_manager.py # dlrover/python/tests/test_args.py # dlrover/python/tests/test_diagnosis_manager.py # docs/deployment/argument.md
# Conflicts: # dlrover/python/common/constants.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
e33cfb4
into
intelligent-machine-learning:master
What changes were proposed in this pull request?
Why are the changes needed?
For details, please see the design document in the current PR.
Does this PR introduce any user-facing change?
User can enable or disable the pre-check function through job args. For details, please see the development document in the current PR.
How was this patch tested?
UT and simple training job.