add Training event Exporter #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyzcj
requested review from
workingloong,
samplise,
BalaBalaYi and
majieyue
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
+ Coverage 81.61% 82.14% +0.52%
==========================================
Files 240 253 +13
Lines 24062 25288 +1226
==========================================
+ Hits 19638 20772 +1134
- Misses 4424 4516 +92 ☔ View full report in Codecov by Sentry. |
added 16 commits
January 22, 2025 20:21
add test emitter
BalaBalaYi
reviewed
Feb 5, 2025
BalaBalaYi
reviewed
Feb 6, 2025
BalaBalaYi
reviewed
Feb 6, 2025
BalaBalaYi
reviewed
Feb 6, 2025
added 11 commits
February 6, 2025 18:20
…ization - Introduce a new abstract `start()` method in the EventExporter base class - Implement `start()` method for AsyncExporter to control thread initialization - Add `start()` method to TextFileExporter and ConsoleExporter - Modify default exporter initialization to call `start()` method - Update tests to call `start()` before using AsyncExporter
- Update Config class to inherit from Singleton - Remove global config and logger getter functions - Modify error_handler, exporter, and emitter to use Config.singleton_instance() - Rename global logger variables for consistency - Simplify thread-safe singleton access for configuration
BalaBalaYi
reviewed
Feb 7, 2025
BalaBalaYi
reviewed
Feb 7, 2025
BalaBalaYi
reviewed
Feb 7, 2025
added 2 commits
February 7, 2025 21:06
- Rename `DLRoverMaster` to `DLRoverMasterEvent` - Rename `DLRoverAgent` to `DLRoverAgentEvent` - Rename `DLRoverCommon` to `DLRoverCommonEvent` - Update import statements and references across multiple files - Update documentation to reflect new class names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a Training Event Exporter SDK that enables training processes and DLRover processes to export key events to log files in a standardized format.
Why are the changes needed?
DLRover requires detailed training process information to make informed fault repair decisions. This information includes but is not limited to:
The SDK provides a standardized way to collect and export these training events, making it easier for DLRover to monitor and manage training processes effectively.
Does this PR introduce any user-facing change?
No, this is an internal SDK implementation that doesn't affect end users directly.
How was this patch tested?