Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set USE_XCCL default as OFF #1318

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Set USE_XCCL default as OFF #1318

merged 3 commits into from
Jan 24, 2025

Conversation

Chao1Han
Copy link
Contributor

No description provided.

@@ -38,7 +38,7 @@ list(APPEND CMAKE_MODULE_PATH ${TORCH_XPU_OPS_ROOT}/cmake/Modules)
include(${TORCH_XPU_OPS_ROOT}/cmake/SYCL.cmake)
include(${TORCH_XPU_OPS_ROOT}/cmake/BuildFlags.cmake)

option(USE_XCCL "Build with XCCL support" ON)
option(USE_XCCL "Build with XCCL support" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, XCCL backend does not get ready in PyTorch release. So we disable it by default (you still can build XCCL with USE_XCCL=1) and will enable again in PyTorch 2.8 release by our expectation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite unfortunate since a number of projects awaits distributed support fromXPU. What are outstanding issues preventing to enable XCCL by default?

@chuanqi129
Copy link
Contributor

@Chao1Han Please add export USE_XCCL=1 in https://github.com/intel/torch-xpu-ops/blob/main/.github/workflows/_linux_build.yml#L91, to make sure the torch-xpu-ops CICD build with XCCL

@zhangxiaoli73
Copy link

@gujinghui Please be aware that we plan to disable XCCL by default (also a suggestion from Validation) and enable when we are ready for XCCL binary release.

@chuanqi129 chuanqi129 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit a6f4c32 Jan 24, 2025
7 checks passed
@chuanqi129 chuanqi129 deleted the xccl/off branch January 24, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants